Use file browser dialog for local path #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddstr13
reviewed
Dec 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 21.83% 21.88% +0.04%
==========================================
Files 63 63
Lines 8677 8682 +5
Branches 1411 1411
==========================================
+ Hits 1895 1900 +5
Misses 6763 6763
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
I added some test cases. Personally I could only test nfs and smb but I don't see why the other types would not work. |
oddstr13
reviewed
Dec 21, 2024
|
oddstr13
added
Native Mode
oddstr13
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a file browser dialog instead of a basic plaintext dialog for the local path. Kodi returns credentials for instance in smb paths selected using a browser dialog. It's better to strip these out so they do not become visible in the list.